chore(preprod): Add image dedupping logic when creating ParsedAssets folder#2855
Closed
NicoHinderling wants to merge 1 commit intomasterfrom
Closed
chore(preprod): Add image dedupping logic when creating ParsedAssets folder#2855NicoHinderling wants to merge 1 commit intomasterfrom
NicoHinderling wants to merge 1 commit intomasterfrom
Conversation
NicoHinderling
changed the title
noahsmartin
reviewed
Oct 17, 2025
| let (structuredThemeStore, assetKeys) = initializeCatalog(from: file) | ||
|
|
||
| var images: [String: CGImage] = [:] | ||
| var seenImageKeys: [String: String] = [:] // SHA256 -> imageId mapping |
Contributor
There was a problem hiding this comment.
This doesn't seem right to me, where is an equivalent mapping used in the emerge code?
Contributor
Author
There was a problem hiding this comment.
I had some misunderstanding , we do logic to set the isDuplicate flag, but we don't actually do de-dupping in the parsing. The main misunderstanding I had was around how we will no longer be doing app thinning automatically for users, so I think I'm going to close this PR for now
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is logic that we have in the emerge ios code but not here. I noticed that when testing HackerNews, we had duplicate images showing up and because of that, duplicate image insights. This change fixes both
Before:
After:
